<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118276/">https://git.reviewboard.kde.org/r/118276/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kate and KDE Frameworks.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 9:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kwrite has org.kate-editr.kwrite as dbusname in its desktop file, but the application registers org.kde.kwrite instead (in qt5 org.kate-editor wouldn't even work because of the dash). this makes klauncher misbehave and KRun() be blocking freezing the caller until kwrite is closed.
the patch gives org.kde.kwrite in the desktop file
possibly related to
https://bugs.kde.org/show_bug.cgi?id=335069
(even tough kate seems to have the proper name, no probably unrelated)
Question for frameworks: should KRun() not freeze when such condition is encountered?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwrite/CMakeLists.txt <span style="color: grey">(5f461b2)</span></li>
<li>kwrite/org.kde.kwrite.desktop <span style="color: grey">(ba8db4b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118276/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>