<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118217/">https://git.reviewboard.kde.org/r/118217/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">was to prevent outline box animation towards the taskbar (iirc)
imo should only make sense in the "showing desktop" case (which is more or less detectable by the kwin core/effects) - and the animating effects completely ignored it anyway.</pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On May 20th, 2014, 11:55 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 20, 2014, 11:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize
If the animation argument was set to false a KWin specific client message
was used. But the implementation was incomplete as it's not part of
_NET_SUPPORTED and by that the implementation does not check whether the
window manager does support this or not.
According to lxr this was only used by SuperKaramba and korgac.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kwindowsystem.h <span style="color: grey">(9acf537240967f41f92ce4caa163a380bc2bf945)</span></li>
<li>src/kwindowsystem.cpp <span style="color: grey">(e93b4c38b485160656d932b326b9416efa484a6f)</span></li>
<li>src/kwindowsystem_p.h <span style="color: grey">(925a722a1b5f1736bbbf400983843a2c6f3a3b9c)</span></li>
<li>src/kwindowsystem_p_x11.h <span style="color: grey">(6d05775f1f1a5b7ec577533100d39b14eb9f2818)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(ea11d10b7a3de05464c4066018ca2c96673f6b0d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118217/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>