<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118115/">https://git.reviewboard.kde.org/r/118115/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6c56d494f8dfaf157e9c8682d345446ad7052655 by Patrick Spendrin to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 13th, 2014, 2:56 p.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kate, KDE Frameworks, kdewin, and Christoph Cullmann.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated May 13, 2014, 2:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">adapt to ecm_add_test
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">mingw
I have no idea how the current state without this patch would be on windows, since this patch is required to run the tests at all.
The following tests FAILED:
34 - movingrange_test (Failed)
35 - kateview_test (Failed)
42 - completion_test (Failed)
43 - indenttest (Failed)
44 - commands_test (Failed)
45 - scripting_test (SEGFAULT)
46 - bug313759 (Failed)
51 - keys (Failed)
If some of these now fail on Linux too, please tell me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(24b36666f1f711d41d692b48b90ba0830812f80a)</span></li>
<li>autotests/src/vimode/CMakeLists.txt <span style="color: grey">(1bac4ff5670d9ba60b019365c08aa9de50f8f192)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>