<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118114/">https://git.reviewboard.kde.org/r/118114/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Alex Merry</p>


<br />
<p>On May 13th, 2014, 1:53 p.m. UTC, Aurélien Gâteau wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>


<p style="color: grey;"><i>Updated May 13, 2014, 1:53 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Test calling ecm_process_po_files_as_qm() without INSTALL_DESTINATION argument
- Test calling ecm_install_po_files_as_qm() with CMAKE_INSTALL_LOCALEDIR set and with LOCALE_INSTALL_DIR set


</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ecm tests still pass.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tests/ECMPoQmToolsTest/CMakeLists.txt <span style="color: grey">(eabf2b8)</span></li>

 <li>tests/ECMPoQmToolsTest/check_tree.cmake.in <span style="color: grey">(71cbaa8)</span></li>

 <li>tests/ECMPoQmToolsTest/only-process.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/po-custom-dir1/es/custom-dir1-install-test.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/po-custom-dir1/fr/custom-dir1-install-test.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/po-custom-dir2/es/custom-dir2-install-test.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/po-custom-dir2/fr/custom-dir2-install-test.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/process-and-install.po <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMPoQmToolsTest/test.po <span style="color: grey">(107d1b0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118114/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>