<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117919/">https://git.reviewboard.kde.org/r/117919/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 12th, 2014, 3:18 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed looks like something which got forgotten along the way. K4About* is supposed to be the porting tool, so let's have this one in even if that's SIC.</pre>
</blockquote>
<p>On May 13th, 2014, 3:16 a.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be clear, should I remove the deprecated ctor too, or just the deprecated single-license stuff as in this patch set?
Also, the are deprecated catalogName getters/setters too that I missed noticing earlier, but they're marked for KF6 so I'm not proposing to remove those.</pre>
</blockquote>
<p>On May 13th, 2014, 10:41 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The catalogName stuff (including the constructor) I deprecated about a month ago. I didn't remove it in order to keep SC, but if we're breaking that anyway, maybe it makes sense to ditch that stuff as well.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, will remove all the deprecated stuff, should land in a few minutes...</pre>
<br />
<p>- Michael</p>
<br />
<p>On May 1st, 2014, 1:03 a.m. UTC, Michael Pyne wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Pyne.</div>
<p style="color: grey;"><i>Updated May 1, 2014, 1:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This completes a "KDE5" porting task for KCoreAddons, by moving KAboutData::LicenseKey and KAboutData::NameFormat enums into KAboutLicense.
This is mostly a mechanical port, however the requirement to keep the deprecated (for KF5) KAboutData ctor requires moving the KAboutLicense class ahead of KAboutData in the header. I wonder why we have this along with K4AboutData however, surely it would make sense to have unported apps simply use that (or declare a license) instead?
I also removed the deprecated (since KDE 4) single-license accessors since multiple licenses are possible.
Finally the test suite was updated (a lot of tests relating to single-license calls were removed). If the single-license calls are necessary those can be added back as well but they've been deprecated for awhile, and there is K4AboutData available.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KCoreAddons builds, tests pass, but I would imagine downstream code needs porting after this to fix the naming of the license in its KAboutData ctor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kaboutdatatest.cpp <span style="color: grey">(f4f4f18)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(a87141e)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(82da19b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>