<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118084/">https://git.reviewboard.kde.org/r/118084/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 12, 2014, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move sonnet plugins into kf5/sonnet subdir of plugin install dir
This should help minimise coinstallability issues with KF6.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autotests pass. Inspecting the output of the sonnet-test_core test shows that all the installed plugins are being found.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/loader.cpp <span style="color: grey">(108206088d698dbc67b69d2582fc06145d8c2067)</span></li>
<li>src/plugins/aspell/CMakeLists.txt <span style="color: grey">(4f1828015984e7fd0c07b1870f4f4e7d38ce3210)</span></li>
<li>src/plugins/enchant/CMakeLists.txt <span style="color: grey">(e89f0c8225db6d19195eed12284a13d2ac6e9a2d)</span></li>
<li>src/plugins/hspell/CMakeLists.txt <span style="color: grey">(9fde5c4883b9df5efbc645e4c69f839786bd1cc3)</span></li>
<li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(bac08aa1624bbec1cb1b83e56db159ed54a95c30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118084/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>