<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118080/">https://git.reviewboard.kde.org/r/118080/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move kioslaves to the "kf5/kio" subdirectory of the plugin directory
This should help minimise coinstallability issues with KF6.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests pass (after making sure the old plugins were removed), except for the test fixed by https://git.reviewboard.kde.org/r/118082/ .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kprotocolinfotest.cpp <span style="color: grey">(9ca0b8e4ba2da2cfd3c65951c05a5f4595265354)</span></li>
<li>src/ioslaves/file/CMakeLists.txt <span style="color: grey">(5d060df8fd513bb567616d74bc5068ab0d46e6a6)</span></li>
<li>src/ioslaves/file/file.protocol <span style="color: grey">(6ac8dbbc2019b1cb8cbf55abb6c9d128613527e1)</span></li>
<li>src/ioslaves/ftp/CMakeLists.txt <span style="color: grey">(b2381ab337c8a1d5159a6d2dab07e75d80ad913e)</span></li>
<li>src/ioslaves/ftp/ftp.protocol <span style="color: grey">(ae452d2daac5fa9c397f6749a69cdf29cf28ceaf)</span></li>
<li>src/ioslaves/help/CMakeLists.txt <span style="color: grey">(7d60e81a76b5590cf97fe778035c6bdc9d7e1250)</span></li>
<li>src/ioslaves/help/ghelp.protocol <span style="color: grey">(ec5e50a34dfd389993ea3b053d9f9b681064ae66)</span></li>
<li>src/ioslaves/help/help.protocol <span style="color: grey">(3204985c105d495d14cc225e90f184aa5ad24321)</span></li>
<li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(dd2147e5133016e9ff08dc683c1f09c5cd17a509)</span></li>
<li>src/ioslaves/http/http.protocol <span style="color: grey">(435824ca8e29aafccb917077687861d3890f918d)</span></li>
<li>src/ioslaves/http/https.protocol <span style="color: grey">(9e289a8231842e6eb8d1b12888898fe2a84297c9)</span></li>
<li>src/ioslaves/http/webdav.protocol <span style="color: grey">(477855c1ba8bd034a4c782a2aa465ab76b25596d)</span></li>
<li>src/ioslaves/http/webdavs.protocol <span style="color: grey">(842c880dfc19bdc79dab49c298aa896c4666b54e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118080/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>