<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118083/">https://git.reviewboard.kde.org/r/118083/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

This should help minimise coinstallability issues with KF6.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed old plugins, build and installed, ran kbuildsycoca5.

Autotest passed, and manual test listed system-installed emoticon themes.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/providers/adium/CMakeLists.txt <span style="color: grey">(dbee5e2d5367a75eafcbe193f60b9d278185cec3)</span></li>

 <li>src/providers/adium/emoticonstheme_adium.desktop <span style="color: grey">(e3502d32c1f54adb04bdd36c699a20c74d349532)</span></li>

 <li>src/providers/kde/CMakeLists.txt <span style="color: grey">(e475b686b150f3d41141824dbdcba6975a9ac53d)</span></li>

 <li>src/providers/kde/emoticonstheme_kde.desktop <span style="color: grey">(fe23f7d6c7a09e1e9132b987598ae0364bb4cbec)</span></li>

 <li>src/providers/pidgin/CMakeLists.txt <span style="color: grey">(99c5bbcb124847d13eec9cbcd3650bf98b0dd2f0)</span></li>

 <li>src/providers/pidgin/emoticonstheme_pidgin.desktop <span style="color: grey">(2dcef956e9c709a552015242943ba5a62ecdfb12)</span></li>

 <li>src/providers/xmpp/CMakeLists.txt <span style="color: grey">(6b45c898a783ee04dad53aab8529b1dba5d28630)</span></li>

 <li>src/providers/xmpp/emoticonstheme_xmpp.desktop <span style="color: grey">(a0cd7b7390c915914aff1ebddfa0c2a497201ed2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118083/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>