<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117944/">https://git.reviewboard.kde.org/r/117944/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 51eca9b6a8220e25ff3c469d757185651c9242e5 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 2nd, 2014, 2:23 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 2, 2014, 2:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite the PIC image format handler
It now uses QDataStream to deal with endianness. It also supports
several QImageIOHandler options.
This comes with a more comprehensive test suite than the old code. Note
that the old test suite was incorrect as the old code wrote the floats
in the header out incorrectly (although no-one noticed because no
software seems to care about those values).
All the test PIC files in the test suite appear correct according to the
specification (by inspection with Okteta). Unfortunately, there is a
lack of other freely-available software that reads and writes PIC files
(the main application that uses them is proprietary), and so this is the
best I can do.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autotests now all pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(86c540c81b6a15f908b9435a2309d9123a6ab1d4)</span></li>
<li>autotests/long-runs.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-alpha-uncompressed.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-alpha.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-alpha.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-simple-color-uncompressed.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-simple-color.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/4x4-simple-color.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/long-comment.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/long-runs.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/long-runs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pic/short-comment.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/pictest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/bw.pic <span style="color: grey">(552c2e8eb15e30018ae365a5994e8d8d9a9d442e)</span></li>
<li>autotests/read/pic/bw.png <span style="color: grey">(e2d506bb3da276c09b8f9388dc8ad6b96f987f5e)</span></li>
<li>autotests/read/pic/bwa.pic <span style="color: grey">(affc603bebdd64a1d63b5477f6c71e827405733b)</span></li>
<li>autotests/read/pic/bwa.png <span style="color: grey">(a75415012846b5eead134ac502aa740c0cf1cfa7)</span></li>
<li>autotests/read/pic/rgb.pic <span style="color: grey">(f8a1b9cf58589d407006a6b64eefe37b6786d6a8)</span></li>
<li>autotests/read/pic/rgb.png <span style="color: grey">(267d67841ad5f80e0f36cbf514c33d6e9cac146b)</span></li>
<li>autotests/read/pic/rgba.pic <span style="color: grey">(05fed0fccecb597d236d30fd020e681a96ea69a6)</span></li>
<li>autotests/read/pic/rgba.png <span style="color: grey">(cb0cae071b4e59cd18f168bb93f824b93bab3aa8)</span></li>
<li>autotests/write/bw.pic <span style="color: grey">(552c2e8eb15e30018ae365a5994e8d8d9a9d442e)</span></li>
<li>autotests/write/bwa.pic <span style="color: grey">(affc603bebdd64a1d63b5477f6c71e827405733b)</span></li>
<li>autotests/write/rgb.pic <span style="color: grey">(f8a1b9cf58589d407006a6b64eefe37b6786d6a8)</span></li>
<li>autotests/write/rgba.pic <span style="color: grey">(05fed0fccecb597d236d30fd020e681a96ea69a6)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: grey">(59472ae49e473faa7ab78db6eb9f3623fd7b6a4b)</span></li>
<li>src/imageformats/pic.h <span style="color: grey">(add0a35bb205b989d4485cec83ce49c23c701ded)</span></li>
<li>src/imageformats/pic.cpp <span style="color: grey">(9d8a7ede31c5c03a699d6a76c88aeb5e3d37ac4a)</span></li>
<li>src/imageformats/pic_read.cpp <span style="color: grey">(484c63426723e04e5c7e96ae5355ccceccab03f4)</span></li>
<li>src/imageformats/pic_rw.h <span style="color: grey">(2cc958927403de57049bbd7cb3200f0b7489da3c)</span></li>
<li>src/imageformats/pic_write.cpp <span style="color: grey">(0632eebd507e58e480856b53e71c24afc543de26)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117944/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>