<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117888/">https://git.reviewboard.kde.org/r/117888/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, it looks like nothing that has been ported is using it (and barely anything that hasn't been ported ever used it).
However, it should be marked as deprecated, and the apidocs should indiciate how to port away from it.
Also, I disagree that there's nothing interesting in the history. Most of the interesting stuff is in the kdelibs history, but that can be grafted on if the commit is constructed properly -- in particular, if you keep the initial commit from the kunitconversion repository.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On April 29th, 2014, 9:24 p.m. UTC, John Layt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By John Layt.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 9:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KCurrencyCode is not needed in KUnitConversion and imposes an unneeded
dependency on KConfigCore, so move it to kdelibs4support back with the
rest of KLocale. Note no attempt has been made to move the history as
there was nothing of significance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ff8199e8b80078d40b403800230448ad1a7c85c9)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/adf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/adp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/aed.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/afa.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/afn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/all.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/amd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ang.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/aoa.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/aon.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ars.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ats.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/aud.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/awg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/azm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/azn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bam.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bbd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bdt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bef.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bgl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bgn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bhd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bif.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bmd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bnd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bob.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bov.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/brl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bsd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/btn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bwp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/byr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/bzd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cad.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cdf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/chf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/clf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/clp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cny.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cop.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cou.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/crc.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cuc.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cup.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cve.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/cyp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/czk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/dem.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/djf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/dkk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/dop.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/dzd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/eek.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/egp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ern.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/esp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/etb.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/eur.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/fim.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/fjd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/fkp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/frf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gbp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gel.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ghc.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ghs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gip.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gmd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gnf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/grd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gtq.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gwp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/gyd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/hkd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/hnl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/hrk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/htg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/huf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/idr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/iep.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ils.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/inr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/iqd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/irr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/isk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/itl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/jmd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/jod.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/jpy.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kes.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kgs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/khr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kmf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kpw.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/krw.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kwd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kyd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/kzt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lak.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lbp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lkr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lrd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lsl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ltl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/luf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lvl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/lyd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mad.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mdl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mga.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mgf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mkd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mlf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mmk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mnt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mop.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mro.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mtl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mur.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mvr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mwk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mxn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mxv.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/myr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mzm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/mzn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/nad.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ngn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/nio.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/nlg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/nok.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/npr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/nzd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/omr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pab.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pen.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pgk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/php.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pkr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pln.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pte.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/pyg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/qar.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/rol.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ron.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/rsd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/rub.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/rur.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/rwf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sar.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sbd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/scr.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sdd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sdg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sek.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sgd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/shp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sit.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/skk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sll.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/sos.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/srd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/srg.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ssp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/std.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/svc.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/syp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/szl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/thb.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tjs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tmm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tmt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tnd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/top.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tpe.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/trl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/try.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ttd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/twd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/tzs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/uah.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/ugx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/usd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/usn.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/uss.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/uyu.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/uzs.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/veb.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/vnd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/vuv.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/wst.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xaf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xag.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xau.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xcd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xof.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xpd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xpf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/xpt.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/yer.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/yum.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/zar.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/zmk.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/zwd.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/currency/zwl.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1db2612bdc625b7267d31ce773ecfdcddc6ae045)</span></li>
<li>src/kdecore/kcurrencycode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kdecore/kcurrencycode.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117888/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>