<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Apr 26, 2014 at 6:07 AM, Jeremy Whiting <span dir="ltr"><<a href="mailto:jpwhiting@kde.org" target="_blank">jpwhiting@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2<br>
on the frameworks branch of it's git repo. If someone would take a<br>
look and check if I did anything wrong that would be great. It builds<br>
here and the tests all pass, but a second (or more) set of eyes is<br>
always welcome.<br>
<br>
I guess another step to take with it would be to port it away from<br>
KDELibs4Support and KIO::NetAccess ?<br>
<br>
Any comments welcome, thanks,<br>
Jeremy<br>
_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br>
</blockquote></div><br></div><div class="gmail_extra">Hi Jeremy!</div><div class="gmail_extra">I just built it, it's indeed looking good.</div><div class="gmail_extra"><br></div><div class="gmail_extra">I just committed a couple of changes because it was not setting the library's name properly, but it's a small detail.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Cheers!</div><div class="gmail_extra">Aleix</div></div>