<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Apr 18, 2014 at 4:54 PM, Burkhard Lück <span dir="ltr"><<a href="mailto:lueck@hube-lueck.de" target="_blank">lueck@hube-lueck.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Am Donnerstag, 17. April 2014, 17:42:25 schrieb Aleix Pol:<br>
<div>> On Mon, Apr 14, 2014 at 12:57 PM, Burkhard Lück <<a href="mailto:lueck@hube-lueck.de" target="_blank">lueck@hube-lueck.de</a>> wrote:<br>
> > Hi,<br>
> ><br>
> > I found a lot of docbook issues in many workspace repos, i. e. code but no<br>
> > corresponding docbook in a repo and vice versa:<br>
> ><br>
</div>Just to clarify my pov and this list:<br>
Code + corresponding docbook should to be in the same repo, so that both are<br>
installed together.<br>
Using a script I have searched a repo for all X-DocPath entries in *.desktop<br>
files = Code and checked if the corresponding docbook is in the repo as well<br>
and the other way round - search all docbooks and check if the repo has a<br>
desktop file with the X-DocPath for this docbok.<br>
<div><br>
> > kde-cli-tools:<br>
> > mv plasma-desktop/doc/kcontrol/filetypes/<br>
> > kde-cli-tools/doc/kcontrol/filetypes/<br>
><br>
> Are we sure about that? I skimmed through the file and it's describing the<br>
> KCM module...<br>
><br>
</div>Yes, that is true.<br>
And keditfiletype/filetypes.desktop indicates that this is the KCM-Code with the<br>
X-DocPath in filetypes.desktop for this docbook.<br>
<div><br>
> > khelpcenter:<br>
> > mv doc/* doc/khelpcenter<br>
> > mv kde-runtime/doc/[onlinehelp|fundamentals|glossary] /doc<br>
><br>
> Done<br>
><br>
</div>Thanks.<br>
<div><br>
> > /plugins/plasma.desktop X-DocPath=help:/plasma-desktop/index.html???<br>
> > mv plasma-desktop/doc/plasma-desktop/ /doc/<br>
><br>
> I'm unsure what this means, sorry.<br>
><br>
</div>plasma-desktop is a docbook with general infos about plasma, not tied to any<br>
specific code and via plugins/plasma.desktop it is a top level item in the<br>
navigation tree of khelpcenter, therefore the docbook has to be installed<br>
together with khelcenter.<br>
<div><br>
> > khotkeys:<br>
> > mv kde-workspace/doc/kcontrol/khotkeys doc/kcontrol/khotkeys<br>
><br>
> It's in plasma-desktop/doc/kcontrol/khotkeys<br>
><br>
</div>Sorry my fault, docbook is in plasma-desktop, and code is in khotkeys repo<br>
(kcm_hotkeys dir with X-DocPath=kcontrol/khotkeys/index.html.<br>
There for the khotkeys docbook has to be moved here.<br></blockquote><div>Done.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>
> > kio-extras:<br>
> > missing docbooks kcontrol/kcmcgi/ + kcontrol/trash/ (from superfluous<br>
> > docbook /doc/kioslave/network/ where is the code?<br>
><br>
> They are both in Plasma-Desktop, with the rest of KControl modules.<br>
><br>
</div>cgi kcm code is in cgi/kcmcgi with X-DocPath=kcontrol/kcmcgi/index.html in<br>
kcmcgi.desktop, therefore the cgi docbook should be in this repo as well<br>
<br>
trash kcm code is in trash dir with X-DocPath=kcontrol/trash/index.html in<br>
kcmtrash.desktop, therefore the trash docbook should be in this repo as well<br></blockquote><div>Done.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> > kwindowsaddons:<br>
> > missing docbooks kcontrol/platform/+ kwinshutdown/ ? did we ever had<br>
> > these docbooks?<br>
><br>
> I don't think so.<br>
><br>
> > plasma-desktop:<br>
> > Docbooks, but no corresponding X-DocPath entries<br>
> ><br>
> > /doc/kcontrol/bookmarks/index.docbook<br>
</div>code in konqueror/settings/kio/<br>
> > /doc/kcontrol/cache/index.docbook<br>
code in konqueror/settings/kio/<br>
> > /doc/kcontrol/clock/index.docbook<br>
code in plasma-desktop/kcms/dateandtime/ -> OK<br>
> > /doc/kcontrol/cookies/index.docbook<br>
code in konqueror/settings/kio/<br>
> > /doc/kcontrol/cursortheme/index.docbook<br>
> > /doc/kcontrol/ebrowsing/index.docbook<br>
code in konqueror/settings/ebrowsing/<br>
> > /doc/kcontrol/filemanager/index.docbook<br>
code in konqueror/settings/konq/<br>
> > /doc/kcontrol/filetypes/index.docbook<br>
code in workspace/kde-cli-tools/keditfiletype/<br>
> > /doc/kcontrol/history/index.docbook<br>
code in konqueror/sidebar/history_module/<br>
> > /doc/kcontrol/kcm_ssl/index.docbook<br>
code in kdelibs4support/src/kssl/kcm/<br>
> > /doc/kcontrol/kcmcgi/index.docbook<br>
code in kio-extras/cgi/kcmcgi/<br>
> > /doc/kcontrol/kcmcss/index.docbook<br>
code in konqueror/settings/konqhtml/css/<br>
> > /doc/kcontrol/kcmsmserver/index.docbook<br>
code in plasma-workspace/ksmserver/kcm/<br>
> > /doc/kcontrol/khotkeys/index.docbook<br>
code in workspace/khotkeys/kcm_hotkeys/<br>
> > /doc/kcontrol/khtml-adblock/index.docbook<br>
code in konqueror/settings/konqhtml/<br>
> > /doc/kcontrol/khtml-behavior/index.docbook<br>
code in konqueror/settings/konqhtml/<br>
> > /doc/kcontrol/khtml-general/index.docbook<br>
code in konqueror/settings/konqhtml/<br>
> > /doc/kcontrol/khtml-java-js/index.docbook<br>
code in konqueror/settings/konqhtml/<br>
> > /doc/kcontrol/khtml-plugins/index.docbook<br>
code in nsplugins/<br>
> > /doc/kcontrol/netpref/index.docbook<br>
code in konqueror/settings/kio/<br>
> > /doc/kcontrol/paths/index.docbook<br>
code in plasma-desktop/kcms/desktoppaths/ -> OK<br>
> > /doc/kcontrol/performance/index.docbook<br>
code in konqueror/settings/performance/<br>
> > /doc/kcontrol/powerdevil/index.docbook<br>
code in extragear/base/powerdevil<br>
> > /doc/kcontrol/proxy/index.docbook<br>
code in konqueror/settings/kio/<br>
> > /doc/kcontrol/smb/index.docbook<br>
code in konqueror/settings/kio/<br>
> > /doc/kcontrol/solid-device-automounter/index.docbook<br>
code in kde-runtime/solid-device-automounter/kcm/<br>
> > /doc/kcontrol/splashscreen/index.docbook<br>
code in plasma-workspace/ksplash/kcm/<br>
> > /doc/kcontrol/trash/index.docbook<br>
code in kio-extras/trash/<br>
> > /doc/kcontrol/useragent/index.docbook<br>
code in konqueror/settings/kio/<br>
><br>
As this list shows a lot of kcm docbooks here have the corresponding code in<br>
other repos, is that intended?<br></blockquote><div>It's not intended, it's unfortunate.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> So we want the kcm desktop files to link to those?<br>
> For example, there's the clock kcm, which desktop file is in<br>
> plasma-desktop/kcms/dateandtime/clock.desktop. It doesn't have such<br>
> X-DocPath but then it doesn't seem to need any move.<br>
><br>
> Should we add it now? Is it already broken in KDE4?<br>
><br>
</div>clock.desktop has X-DocPath=kcontrol/clock/index.html here (and in kde4 as<br>
well) so no need to add it.<br>
<div><br>
> > plasma-workspace:<br>
> > missing docbooks: kcontrol/kcmsmserver/ + kcontrol/splashscreen/<br>
> > mv plasma-desktop/doc/[kcontrol/kcmsmserver|kcontrol/splashscreen]<br>
> > plasma/workspace/doc/<br>
><br>
> Actually in these cases, kcmsmserver and the ksplashscreen kcm should go to<br>
> plasma-desktop instead.<br>
><br>
</div>kcmsmserver code is in plasma-workspace (ksmserver/kcm/kcmsmserver.desktop)<br>
and ksplashscreen code is in plasma-workspace<br>
(ksplash/kcm/ksplashthememgr.desktop), there for these docbooks should go to<br>
plasma-workspace repo, where the code lives.<br></blockquote><div>Moved the kcms to plasma-desktop.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> > superfluous docbooks /doc/PolicyKit-kde/ where is the code?<br>
><br>
> I think here:<br>
> <a href="https://projects.kde.org/projects/extragear/base/polkit-kde-agent-1" target="_blank">https://projects.kde.org/projects/extragear/base/polkit-kde-agent-1</a><br>
><br>
> I don't know if this has been ported yet, but it should probably go to<br>
> either frameworksintegration or plasma-workspace.<br>
><br>
</div>I'd prefer to have the docbook together with the code, so it should go to<br>
extragear/base/polkit-kde-agent-1<br></blockquote><div>It hasn't been ported yet, maybe I can move it to master and then it will still be there when it's ported.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div><br>
--<br>
Burkhard Lück<br>
<br>
_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org" target="_blank">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a></div></div></blockquote><div><br></div><div>Regarding solid-hardware </div>
</div><br></div><div class="gmail_extra">Thanks a lot for the thorough review, it would be good if you could do another run and then create an epics page such as this one [1], so that I can keep track of all the things to be done. I feel like I'm forgetting some</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Aleix</div><div class="gmail_extra"><br></div><div class="gmail_extra">[1] <a href="http://community.kde.org/Frameworks/Epics/New_Runtime_Organization">http://community.kde.org/Frameworks/Epics/New_Runtime_Organization</a></div>
</div>