<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117708/">https://git.reviewboard.kde.org/r/117708/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 23rd, 2014, 3:30 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think after this change many documentation links (at least in khelpcenter) need to be fixed (I can't check now).</pre>
</blockquote>
<p>On April 24th, 2014, 10:39 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That'd need to be confirmed before letting this patch in or not.</pre>
</blockquote>
<p>On April 24th, 2014, 10:54 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right: I checked, and all doc/kioslave/<foo>/CMakeLists.txt have something like:
kdoctools_create_handbook(index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/en SUBDIR kioslave/ftp)
Similar lines are in other kioslave which will be available in kioslaves[-extra].
In addition, I think that also the lines like
X-DocPath=kioslave/<ioslave>/index.html
from src/ioslaves/<ioslave>/<ioslaveprotocol1>.protocol
should be fixed as well (Burkhard?).
There are two "kioslave" references in khelpcenter which could be affected too (khelpcenter/plugintraverser.cpp khelpcenter/plugins/kioslaves.desktop) but I'm not sure now.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Similar lines are in other kioslave which will be available in kioslaves[-extra]
Yes kio-extras should be changed accordingly + kioslaves in other modules (kdepim/kdepimlibs/) with frameworks branches as well
> In addition, I think that also the lines like
> X-DocPath=kioslave/<ioslave>/index.html
> from src/ioslaves/<ioslave>/<ioslaveprotocol1>.protocol
> should be fixed as well (Burkhard?).
These are already fixed in this Review
> There are two "kioslave" references in khelpcenter which could be affected too (khelpcenter/plugintraverser.cpp
> khelpcenter/plugins/kioslaves.desktop) but I'm not sure now.
As far as I read the code these are not affected, but for the sake of consistency they should be adapted as well.
We need to adapt l10n-kf5/scripts/autogen.sh to generate proper CMakeLists.txt for translated docbboks as well,
but that does only make sense, when all docbooks (kcontrol/kioslave/etc) ended up at their final location -
there are still a lot on my list, see http://mail.kde.org/pipermail/kde-frameworks-devel/2014-April/014747.html
Otherwise I am fine with this patch
</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On April 23rd, 2014, 3:24 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated April 23, 2014, 3:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">move kioslave docs path which currently clashes with equivalents from kdelibs4 land.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/kioslave/data/CMakeLists.txt <span style="color: grey">(64ae620)</span></li>
<li>docs/kioslave/file/CMakeLists.txt <span style="color: grey">(42385fb)</span></li>
<li>docs/kioslave/ftp/CMakeLists.txt <span style="color: grey">(935298b)</span></li>
<li>docs/kioslave/help/CMakeLists.txt <span style="color: grey">(cfb29f1)</span></li>
<li>docs/kioslave/help/documentationnotfound/CMakeLists.txt <span style="color: grey">(f2bc0b5)</span></li>
<li>docs/kioslave/http/CMakeLists.txt <span style="color: grey">(2aae4fb)</span></li>
<li>docs/kioslave/mailto/CMakeLists.txt <span style="color: grey">(b0a405e)</span></li>
<li>docs/kioslave/telnet/CMakeLists.txt <span style="color: grey">(07b2d33)</span></li>
<li>docs/kioslave/webdav/CMakeLists.txt <span style="color: grey">(eb45ed5)</span></li>
<li>src/ioslaves/file/file.protocol <span style="color: grey">(07cd4c3)</span></li>
<li>src/ioslaves/ftp/ftp.protocol <span style="color: grey">(70ddcd0)</span></li>
<li>src/ioslaves/help/help.protocol <span style="color: grey">(1bb5801)</span></li>
<li>src/ioslaves/http/http.protocol <span style="color: grey">(2d97cd4)</span></li>
<li>src/ioslaves/http/https.protocol <span style="color: grey">(62a43ad)</span></li>
<li>src/ioslaves/http/webdav.protocol <span style="color: grey">(c0fbd11)</span></li>
<li>src/ioslaves/http/webdavs.protocol <span style="color: grey">(7017c24)</span></li>
<li>src/ioslaves/mailto/kmailservice5.desktop <span style="color: grey">(03838a5)</span></li>
<li>src/ioslaves/protocols/data.protocol <span style="color: grey">(2a57b2e)</span></li>
<li>src/ioslaves/telnet/ktelnetservice5.desktop <span style="color: grey">(052a9d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117708/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>