<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117695/">https://git.reviewboard.kde.org/r/117695/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated April 23, 2014, 8:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">factor out the replace tabs functionality into a method.
I was wrong btw, "indent pasted text" still works as intended.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative.
I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it.
The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just some quick manual tests, it seems to still work as intended.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/document/katedocument.h <span style="color: grey">(83cc0317e26ef077d5292763d0ba9864103bf454)</span></li>
<li>src/document/katedocument.cpp <span style="color: grey">(546d3e6aadc57f24c3fa766ce235addc0f02e3c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117695/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>