<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117275/">https://git.reviewboard.kde.org/r/117275/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated April 14, 2014, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This version adds both short-form and long-form constructors.
I've left the organization domain stuff that was discussed for another RR - this RR just preserves existing behaviour.
I also extended the tests to actually test the new constructors.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Deprecate the catalog name stuff from KAboutData
This is pretty useless - the translation catalog has to be set before
KAboutData is constructed in order to translate its arguments.
Note that we cannot provide a constructor overload that is identical
other than omitting the catalog name argument, as that would be
ambiguous (if 4 strings are passed, it could be either the new
constructor or the old one). So instead, we provide two new
constructors: one requiring at least 4 strings and the license type, and
one only taking 3 strings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kaboutdatatest.cpp <span style="color: grey">(22b013c0626ebea94f371474048c670b3d50dad6)</span></li>
<li>src/lib/kaboutdata.h <span style="color: grey">(cff1e3f67e33657fdd265a82166ef2a04cbcc3d1)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(ce64a13aaa89bb4bc077f05e5f8e175d6a441ead)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117275/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>