<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117435/">https://git.reviewboard.kde.org/r/117435/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 3af23b3f8de4ba9e701e021fa9fe450a712c63f9 by Martin Klapetek to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 8th, 2014, 4:14 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 8, 2014, 4:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This imports KDirSelectDialog from kde4support into frameworksintegration (+ KFileTreeView) and uses the dir select dialog in case the user wants to select a directory.
To not disturb the current code too much, I've created a new class KDEPlatformFileDialogBase, made KDEPlatformFileDialog derive from that as well as KDirSelectDialog, and then KDEPlatformFileDialogHelper stores the KDEPlatformFileDialogBase pointer, which is either the file selector or dialog selector, but with the same API. The API is just added to KDirSelectDialog and it calls its own functions internally.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The testing app in tests/ works exactly as expected; all autotests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(8611b29)</span></li>
<li>src/platformtheme/CMakeLists.txt <span style="color: grey">(e9a2454)</span></li>
<li>src/platformtheme/kdeplatformfiledialogbase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdeplatformfiledialogbase_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: grey">(4621071)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: grey">(c834703)</span></li>
<li>src/platformtheme/kdirselectdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kdirselectdialog_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kfiletreeview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/platformtheme/kfiletreeview_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117435/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>