<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117531/">https://git.reviewboard.kde.org/r/117531/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 13th, 2014, 12:37 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't find the discussion now, but I think that it was decided to keep Messages.sh to not forget it later if the framework introduces some i18n/tr calls. Maybe it could be possible to tune the scripts to be smart and not generate the template if no messages are found? Albert, Aurelien (or anyone else) do you remember what was decided?</pre>
</blockquote>
<p>On April 13th, 2014, 2:44 p.m. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I doubt that such a rule is very rea?iable, e. g. drkonki lost 200 msgs from extraction due to code file moves a few days ago. Having a Messages.sh did not prevent that. </pre>
</blockquote>
<p>On April 13th, 2014, 4:14 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, we decided it may be a good idea to have the Messages.sh in there just in case some strings would added and noone noticed. Of course having a Message.sh won't prevent major fuckups if people don't care, but it should help a bit. Now with "pure" xgettext a Messsages.sh won't create a .po unless there's one string or more. I guess it's the .ts to .po conversion that ends up creating an empty .po file
Personally I would prefer keeping the thing, what is the problem of having it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* empty template might confuse translators + translation apps (not lokalize, ignores it silently)
* consistent behaviour of our tools, and I'd prefer the behaviour of gettext: no msg - no template </pre>
<br />
<p>- Burkhard</p>
<br />
<p>On April 13th, 2014, 9:15 a.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated April 13, 2014, 9:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcrash
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Messages.sh in kcrash generates an empty catalog, because this module does not have GUI strings/tr() calls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Messages.sh <span style="color: grey">(501efe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117531/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>