<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117508/">https://git.reviewboard.kde.org/r/117508/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 12th, 2014, 10:11 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it not make sense to put the compatibility stuff in KIO::Job::addMetaData, rather than the slaves? That way it should maintain compatibility on both the application and slave side (for slaves shipped outside KIO).
Although I guess setMetaData dn mergeMetaData would need the same compat hacks... would that be too much of a performance/maintenance hit?</pre>
</blockquote>
<p>On April 12th, 2014, 10:17 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Interesting idea, but yeah, this is rather rarely used metadata, so hacking the central method for it makes me uneasy in terms of performance and maintenance (there are 4 methods: set, add, add, and merge).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks like the only non-core ioslave to implement this is sftp (unless there's one lurking outside kio-extras, formerly kde-runtime, that implements it). My only concern would be what happens if the app sets the new metadata, and the slave only reads the old metadata. Would that ever result in corrupted data (eg: [segment1][segment1][segment2] instead of [segment1][segment2]), or would it just result in extra network traffic?</pre>
<br />
<p>- Alex</p>
<br />
<p>On April 12th, 2014, 9:55 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated April 12, 2014, 9:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KIO metadata: resume -> range-start, resume_until -> range-end.
This is much more self-explanatory to people wanting to request a byte range,
unrelated to anything like resuming an interrupted download.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/metadata.txt <span style="color: grey">(b2422f9c816f53d5cec9fbdc0e899329cdb26f30)</span></li>
<li>src/core/filecopyjob.cpp <span style="color: grey">(7bce804eb516f882bfc53af207245e847a27ad8d)</span></li>
<li>src/core/scheduler.cpp <span style="color: grey">(f9bc1482b2b8e66b5880f5875567cd485a5b4a5c)</span></li>
<li>src/core/slavebase.h <span style="color: grey">(7417c5e798d843641886fbea62f330524fd12481)</span></li>
<li>src/ioslaves/file/file.cpp <span style="color: grey">(a642a524c3022ce7f039f90d5bc1f577c88631dc)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(79f6144264c03f506309037ed6e8ce429f6c30f0)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(de1a1ddde544229689bd22cd69491a46b8c0dddb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117508/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>