<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117271/">https://git.reviewboard.kde.org/r/117271/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8402305be5e3fb4fef5febca7f1b7cab386f5c09 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On April 1st, 2014, 12:25 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Christoph Feck.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated April 1, 2014, 12:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kiconthemes
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a new test that just checks kicondialog
The old kicondialogtest actually tested KIconButton. That is now
renamed to kiconbuttontest, and there is a new kicondialogtest that
tests KIconDialog.
KIconDialog: do not connect to a signal that does not exist
QDialog::finished(int) does what we want, so use that instead.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/CMakeLists.txt <span style="color: grey">(b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3)</span></li>
<li>tests/kiconbuttontest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kicondialog.cpp <span style="color: grey">(4b241c1591b321486c925ef5e61f09bc7b6ddd1c)</span></li>
<li>tests/kicondialogtest.cpp <span style="color: grey">(66432ba878a4133ea3210089d3fdfbaec145bf1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117271/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>