<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117195/">https://git.reviewboard.kde.org/r/117195/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 31, 2014, 2:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, but let's see what dfaure thinks about it.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use the new name for the error codes
ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*.
Replace COULD_NOT with CANNOT in the error code enum
This makes the error code names more consistent. The old versions are
kept for backwards-compatibility.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/global.h <span style="color: grey">(be8e5481c8146c2d0737be06f034cdccc1573f79)</span></li>
<li>src/core/job_error.cpp <span style="color: grey">(1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(3158628af2dc8ee88a0ac0d968748d6b50a8da33)</span></li>
<li>src/ioslaves/help/kio_help.cpp <span style="color: grey">(df3e934b5cac7428bd1525d5de1b3fedd9b16394)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(49037701772f88e9a96bc3110f1f04fccb810ca8)</span></li>
<li>src/ioslaves/file/file_unix.cpp <span style="color: grey">(bb4d6003985269464c380927d51eaf9ed602ade1)</span></li>
<li>src/ioslaves/file/file.cpp <span style="color: grey">(6387d7f29df2c0a26952be5255438361c37ed082)</span></li>
<li>src/core/tcpslavebase.cpp <span style="color: grey">(ea0434e19a7fb35cc708dece1ff904d6739aa4de)</span></li>
<li>src/core/slavebase.h <span style="color: grey">(4726915da0757c64ab735f586142806891b517d1)</span></li>
<li>src/widgets/accessmanagerreply_p.cpp <span style="color: grey">(4322e0275f57f10aeba2ea8381f53d06f6b6fe25)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117195/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>