<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117074/">https://git.reviewboard.kde.org/r/117074/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e3a717f7fa1dc183f275d5fc8c78ae927aa279eb by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 26th, 2014, 4:05 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 4:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KPluginFactory: remove argumented contructor and componentName()
The Qt plugin system does not pass any arguments to its root object, so
the component name will never get set in normal use. So there's no
point having a method to return it, or in accepting it in the
constructor.
This was the oddly-ported version of a method that returned a
KComponentData, and did not exist in kdelibs 4, hence it is being
removed rather than deprecated.
KDE_NO_DEPRECATED -> KSERVICE_NO_DEPRECATED</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kplugininfo.h <span style="color: grey">(821a1b1fba3cb8624e415b6fd07f65ba2739b286)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: grey">(c48bd5e39ddb597256a269701cfd8efcc5328989)</span></li>
<li>src/sycoca/ksycoca.h <span style="color: grey">(aa4b31c87c79e8182191851b161c0236e2fb35ce)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(0b014e0921e0f0a89dbd6ea8da3950c1f0bbcc25)</span></li>
<li>src/kdeinit/ktoolinvocation.h <span style="color: grey">(42d327fa8b651f7e1531505994d1fce202f437cd)</span></li>
<li>src/kdeinit/ktoolinvocation.cpp <span style="color: grey">(c0d5fde4e1791c114b13fe9f3ce21b97356c661b)</span></li>
<li>src/plugin/kexportplugin.h <span style="color: grey">(15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd)</span></li>
<li>src/plugin/kpluginfactory.h <span style="color: grey">(5d939999b5f8f73ff49baabb516b991e96d6bd8a)</span></li>
<li>src/plugin/kpluginfactory.cpp <span style="color: grey">(cf71906d47aba4decca7d261d84ca1cb67913e7e)</span></li>
<li>src/plugin/kpluginfactory_p.h <span style="color: grey">(103ae5029e508e22c99a727ef5b7568269ba7580)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117074/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>