<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117037/">https://git.reviewboard.kde.org/r/117037/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 10:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactor parameter names
Also add #ifndef KCOMPLETION_NO_DEPRECATED around the implementation of KLineEdit::setUrlDropsEnabled()
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds and tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcombobox.h <span style="color: grey">(80d6573)</span></li>
<li>src/kcombobox.cpp <span style="color: grey">(cbb209e)</span></li>
<li>src/kcompletion.h <span style="color: grey">(3b3b0a6)</span></li>
<li>src/kcompletion.cpp <span style="color: grey">(847cff3)</span></li>
<li>src/kcompletionbox.h <span style="color: grey">(f396746)</span></li>
<li>src/kcompletionbox.cpp <span style="color: grey">(7753643)</span></li>
<li>src/khistorycombobox.h <span style="color: grey">(d1f5eac)</span></li>
<li>src/khistorycombobox.cpp <span style="color: grey">(80261ae)</span></li>
<li>src/klineedit.h <span style="color: grey">(723cb42)</span></li>
<li>src/klineedit.cpp <span style="color: grey">(b426767)</span></li>
<li>src/klineedit_p.h <span style="color: grey">(397abc2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117037/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>