<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116982/">https://git.reviewboard.kde.org/r/116982/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f4b23002eb69a54eaef03750bbf7ff6868eecb21 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 22nd, 2014, 6:46 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 22, 2014, 6:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add FIXME to testregression docs about updating them
kcmshell4 -> kcmshell5
Reword or resolve "### KDE4" TODOs
Those that are just simple binary compatibility issues are resolved,
others are replaced with "TODO".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs, autotests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/BUILDING-TESTREGRESSION <span style="color: grey">(2d799b947263d388ce77d8b16b9529416de3b51f)</span></li>
<li>src/dom/html_form.h <span style="color: grey">(adbb744b64792b517bd7c370a6e3ac4862f5a34e)</span></li>
<li>src/ecma/debugger/breakpointsdock.cpp <span style="color: grey">(3570bd07d705e60274d1a44f6bd344b613ec64c1)</span></li>
<li>src/ecma/debugger/scriptsdock.cpp <span style="color: grey">(30cb846abe39d817435b73252581c673f2d92848)</span></li>
<li>src/ecma/kjs_window.h <span style="color: grey">(6221179601c4904c09be49f0130df08b8109b52e)</span></li>
<li>src/ecma/kjs_window.cpp <span style="color: grey">(f72f49411202e75c2f1b3a949920a0949e63a6d7)</span></li>
<li>src/khtml_part.h <span style="color: grey">(4e272af9f987003a7389c6f924e563f6b02b80a4)</span></li>
<li>src/khtml_part.cpp <span style="color: grey">(2973fa6ce2408aadb5f717a1dc81d9d496543224)</span></li>
<li>src/khtmlpart_p.h <span style="color: grey">(c34648476cb92d0c42be5730d54670ec2b46c218)</span></li>
<li>src/rendering/render_image.cpp <span style="color: grey">(c61a2d209f2a53f3acf3dfcdec896654c4aa8307)</span></li>
<li>src/rendering/render_list.cpp <span style="color: grey">(f74d04f58904866de30a0442d4b8576dd2bb6a7f)</span></li>
<li>src/xml/dom2_eventsimpl.h <span style="color: grey">(9d54af11d6c4524659f777cf2f2440735312cfe7)</span></li>
<li>src/xml/dom2_eventsimpl.cpp <span style="color: grey">(b376fe9c210a16d23308f1443eb7e7c5a3063aaa)</span></li>
<li>src/xml/dom_docimpl.h <span style="color: grey">(83691165437edae603ab4d23d2c844cb0b9391ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116982/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>