<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116998/">https://git.reviewboard.kde.org/r/116998/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116998/diff/1/?file=256388#file256388line80" style="color: black; font-weight: bold; text-decoration: underline;">src/staticxml/staticxmlprovider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool StaticXmlProvider::setProviderXML(const QDomElement &xmldata)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">iconurl</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">setPath</span></span><span class="p">(</span><span class="n">xmldata</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"icon"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">78</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QUrl</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLocalFile</span></span><span class="p">(</span><span class="n">xmldata</span><span class="p">.</span><span class="n">attribute</span><span class="p">(</span><span class="s">"icon"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">iconurl = QUrl::fromLocalFile(xmldata.attribute("icon"));
Or am i missing something obvious now?</pre>
</div>
<br />
<p>- Mark Gaiser</p>
<br />
<p>On March 25th, 2014, 2:37 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 2:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove reference to KDE4_BUILD_TESTS CMake option
Clean up comments about KConfig
Fix KUrl->QUrl porting
QUrl::setPath() does not behave like KUrl::setPath(). Also removed two
very old FIXMEs: the purpose of the condition is clear now (but it was
probably unnecessary when it used KUrl from kdelibs4), and no-one
noticed any issues with the icon URLs during KDE 4, so KUrl probably did
behave as expected.
Remove completely out-of-date README.kdxs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/README.kdxs <span style="color: grey">(f9843068b964f8e3e0a4fec37f938ceb9bba727e)</span></li>
<li>src/core/engine.cpp <span style="color: grey">(4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224)</span></li>
<li>src/staticxml/staticxmlprovider.cpp <span style="color: grey">(56a25654a70a3628573d85adf4a1c49010f23309)</span></li>
<li>src/uploaddialog.cpp <span style="color: grey">(35f34b30d4dc74c93794cb7862d65364685939d1)</span></li>
<li>tests/README.tests <span style="color: grey">(7b590b823b394ca340e14d6729b4229f49946852)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116998/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>