<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116997/">https://git.reviewboard.kde.org/r/116997/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f0727f1d00aa3109a8252888ca6c2e7cd88ff0f3 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 23rd, 2014, 3:48 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 23, 2014, 3:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleanup KDE 4 references in various comments and dox
Remove commented-out KSocks call
No-one noticed its absense through KDE 4...
Remove disabled archive support from ListJob
According to the comments, this has never worked.
Remove the kdestop integration code from fileundomanager
This hasn't worked since KDE 2.1(!)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, compiles, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/listjob.cpp <span style="color: grey">(9ed42eb51f7aa83016a8818f45e88e300eaa726e)</span></li>
<li>src/core/slavebase.h <span style="color: grey">(092289349dee1c0136668e14088ef4e3d41077ba)</span></li>
<li>src/core/slavebase.cpp <span style="color: grey">(b5d5de0f243a9420bcff61102bfca5fadc68c0be)</span></li>
<li>src/core/transferjob.h <span style="color: grey">(6bd4d32d0607153db66461b97cbef5b367f9e27f)</span></li>
<li>src/core/udsentry.h <span style="color: grey">(ff3304fefe1c986e7f5df843ee20473ba41e4b4d)</span></li>
<li>src/filewidgets/kdiroperator.h <span style="color: grey">(a66d733929ec472971814644dc9847433c955491)</span></li>
<li>src/filewidgets/kdiroperator.cpp <span style="color: grey">(17f09d14b859cba26bb474875bab65d2be0bb7a9)</span></li>
<li>src/filewidgets/kfilepreviewgenerator.cpp <span style="color: grey">(c47a309de1305145184ced8fecd042f22cf7dc66)</span></li>
<li>src/widgets/fileundomanager.cpp <span style="color: grey">(7a22532cb5c23ea6dd152fcf22d6a7ff7a02ed88)</span></li>
<li>src/widgets/fileundomanager_p.h <span style="color: grey">(f135f499b2c7d8e96936863eac2a6cd81a84b0e4)</span></li>
<li>src/widgets/kfileitemactions.h <span style="color: grey">(94c7a1db14633be2966eb220cc942d59ebe0ccdc)</span></li>
<li>src/widgets/krun.h <span style="color: grey">(dbdc481d797c364d1cc72a67bc58280fcaf393b1)</span></li>
<li>src/widgets/kurifilter.h <span style="color: grey">(b67cb1f5a1f8b77bd2b70085417c1ce42748bdde)</span></li>
<li>src/widgets/kurlcombobox.cpp <span style="color: grey">(6f76b2c3ace2b7d556dc9351dc9832c93c61c128)</span></li>
<li>src/widgets/pixmaploader.h <span style="color: grey">(a1b9fdaf20d29905d24c668cdd94ab0a48c04053)</span></li>
<li>src/widgets/previewjob.h <span style="color: grey">(0eec0076d8659ce3510d56d5084be0907165aa5c)</span></li>
<li>src/core/job_base.h <span style="color: grey">(63c59c2c6ddaa9879777c788a7aef391dde2e8dd)</span></li>
<li>src/core/kfileitem.h <span style="color: grey">(b09c3c017aab3fac0eed21dc0dcc20b8625d75f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116997/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>