<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116876/">https://git.reviewboard.kde.org/r/116876/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 11:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make the autotests work uninstalled
This also makes them data-driven, separating out the different testcases
in the output, and fixes the "skipping" behaviour (so QSKIP only skips
one testcase and not all of them).
Add a default theme
This was originally the default theme from Kopete, and was called "kde4"
up until this point.
To trace its history, start at:
svn path=/trunk/KDE/kdebase/runtime/; revision=699615
which is also commit a9552cba75e67fb886921d1abc2cb2a09e6efbad of
kde-runtime.
I didn't copy the history from kde-runtime, because there was no history to copy - only the commit noted above actually made it out of svn.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs, tests pass without skipping (both before and after installation).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>themes/Glass/sleep.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/shade.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/rose.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/sad.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/present.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/phone.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/omg.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/note.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/oh.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/love.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(de080764f7d387871ebebf6bfa7541944b618036)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(98b8e43b2f5cbe08dc6b454e2736e809538a0251)</span></li>
<li>autotests/kemoticontest.h <span style="color: grey">(ba31c0bd50b8bf6a75844fb9c41ffdedd6fc34d5)</span></li>
<li>autotests/kemoticontest.cpp <span style="color: grey">(b7dc6f75fb722d63936fb666a51b969d37b84e31)</span></li>
<li>src/core/kemoticons.cpp <span style="color: grey">(bc72e166586ef1271cac2291a9223c2472e1d8b8)</span></li>
<li>tests/main.cpp <span style="color: grey">(13f584a153fbd3612e8702d05368960d6e8e4e59)</span></li>
<li>themes/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/angry.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/bat.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/beer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/biggrin.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/cake.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/camera.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/cat.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/clock.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/cocktail.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/confused.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/cry.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/cup.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/dog.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/email.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/embarassed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/emoticons.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/film.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/foot_in_mouth.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/innocent.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/kiss.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/lightbulb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/star.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/teeth.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/thumbs_down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/thumbs_up.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/tongue.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/undecided.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/unhappy.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/unlove.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/wilted_rose.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>themes/Glass/wink.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>