<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117020/">https://git.reviewboard.kde.org/r/117020/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Type in commit message.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix up KLibLoader autotests
They now test the actual current state of KLibLoader (eg: only Qt5-style
plugins using KPluginFactory are supported).
Improve KLibLoader documentation
Also, add some extra deprecation warnings.
Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning
There is no code left to load these plugins, which have been deprecated
since kdelibs 4.0.
Use KPluginLoader in KLibLoader::factory()
This actually has some chance of succeeding (KLibrary::factory() always
returns 0).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs, tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdecore/klibloader.cpp <span style="color: grey">(bdbdf166964eecef3c534d7fe196fa70dd733c9e)</span></li>
<li>src/kdecore/klibloader.h <span style="color: grey">(55950b6a0ea2916d558bbbc01912f4731ec669d0)</span></li>
<li>autotests/klibloadertest_module.h <span style="color: grey">()</span></li>
<li>autotests/klibloadertest_module.cpp <span style="color: grey">(e434cc46a7c7843186cb0fc4747f876fd5a86bc4)</span></li>
<li>autotests/klibloadertest4_module.h <span style="color: grey">()</span></li>
<li>autotests/klibloadertest4_module.cpp <span style="color: grey">(5179baf6c64228ad6ff50d1733e149740ddedc45)</span></li>
<li>autotests/klibloadertest.cpp <span style="color: grey">(11c14b22d98069ee727d653d41a266b2dcabd820)</span></li>
<li>autotests/klibloadertest.h <span style="color: grey">(84b28ad208159122ef9e8f655b9f8d66d9088ec5)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(c82e3129fc937f54f11db52d553b7f8717c0fffe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117020/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>