<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117017/">https://git.reviewboard.kde.org/r/117017/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 24th, 2014, 10:57 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's a slight difference, and the reason we haven't been doing this for most headers. From KDE4Support you can include headers prefixing KDE/ (such as KDE/KTextEditor/MovingRange). If you remove these that won't be possible anymore thus making porting slightly harder. Arguably people won't be doing KDE/KTextEditor, but then I don't know why people added the KDE/ at all...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep. I'm just fixing this up in KDevelop (where I hit that problem), replacing occurences of 'KDE/'.
The problem with the KTE forward headers are that some of them are already broken (TemplateInterface*, HighlightInterface, and others). This makes it harder than easier to port, because you get compile errors in the middle of the build process.
Arguably, I'd rather force people to get rid off the 'KDE/' prefix (which is easy to script) than to compile again and again to make your code work.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On March 24th, 2014, 10:48 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Dominik Haumann.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 10:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove forward headers for KTextEditor
Some of the headers have actually been removed already. Keeping broken
forward headers actually makes it *more* difficult to port.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/includes/KTextEditor/CommandExtension <span style="color: grey">(4187c61882a83cab906fa87cd16bd18229b6efb5)</span></li>
<li>src/includes/KTextEditor/Command <span style="color: grey">(4187c61882a83cab906fa87cd16bd18229b6efb5)</span></li>
<li>src/includes/KTextEditor/CodeCompletionModelControllerInterface <span style="color: grey">(a92ceb40a0d0afbf42d8b3302492b8e52a7f8505)</span></li>
<li>src/includes/KTextEditor/CodeCompletionModel <span style="color: grey">(3511d00b212e5c56613bf4f06fedc5a5d76cb3bc)</span></li>
<li>src/includes/CMakeLists.txt <span style="color: grey">(bc7d00f85012ec436937fd3d402e9c08e28f6b74)</span></li>
<li>src/includes/KTextEditor/Attribute <span style="color: grey">(6420e896e93532188d08894853176842c7d8ccae)</span></li>
<li>src/includes/KTextEditor/CodeCompletionInterface <span style="color: grey">(41341c38dd92e7c1533b0ba74eceb735408a1d3f)</span></li>
<li>src/includes/KTextEditor/Document <span style="color: grey">(858d360f8ae751c16b03d350d7e415bea400906d)</span></li>
<li>src/includes/KTextEditor/Cursor <span style="color: grey">(2811cda0f69b3c263ac8b2dd210b50f6239f7ff2)</span></li>
<li>src/includes/KTextEditor/ConfigPage <span style="color: grey">(b3904bee10ffc0245bca1a928389237813850ec3)</span></li>
<li>src/includes/KTextEditor/ConfigInterface <span style="color: grey">(0617835fc7621c4c26a2d50ca95d12d8870fffc2)</span></li>
<li>src/includes/KTextEditor/CommandInterface <span style="color: grey">(4187c61882a83cab906fa87cd16bd18229b6efb5)</span></li>
<li>src/includes/KTextEditor/ModificationInterface <span style="color: grey">(50df2902648156dc5cd4630f587add36d320a43a)</span></li>
<li>src/includes/KTextEditor/MessageInterface <span style="color: grey">(41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32)</span></li>
<li>src/includes/KTextEditor/Editor <span style="color: grey">(76d55675c78248875996b0284288a34af303e8c7)</span></li>
<li>src/includes/KTextEditor/HighlightInterface <span style="color: grey">(8c8c94ec679877be7e3965eba86498f06b67a883)</span></li>
<li>src/includes/KTextEditor/MarkInterface <span style="color: grey">(87adf561b38045bdd65fc3f64f24311aa901d8ee)</span></li>
<li>src/includes/KTextEditor/Message <span style="color: grey">(41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32)</span></li>
<li>src/includes/KTextEditor/ParameterizedSessionConfigInterface <span style="color: grey">(8c26b7d418e81072df4e7dffe0038d7fdc1e3010)</span></li>
<li>src/includes/KTextEditor/MovingRange <span style="color: grey">(89f68605ffa863862476831cfb836660a70e4931)</span></li>
<li>src/includes/KTextEditor/MovingInterface <span style="color: grey">(bde16eaca7d68517ce7c2068186eb641daf6eab1)</span></li>
<li>src/includes/KTextEditor/MovingCursor <span style="color: grey">(7c9eb3074e4feace09cca78962caf1ff27bd6394)</span></li>
<li>src/includes/KTextEditor/View <span style="color: grey">(411c995972b47e7a2ad4a385a6924e3a67f8c892)</span></li>
<li>src/includes/KTextEditor/VariableInterface <span style="color: grey">(126a93691700fab3134400907d0ba93a4e275f0d)</span></li>
<li>src/includes/KTextEditor/TextHintInterface <span style="color: grey">(6b05d9a4a45ac8807294599e04c7dc15db076cf0)</span></li>
<li>src/includes/KTextEditor/TemplateInterface2 <span style="color: grey">(de9d9451796710756287bfc2a627f7ae43a006b1)</span></li>
<li>src/includes/KTextEditor/TemplateInterface <span style="color: grey">(0142d17815fabb9136836effa61114aaa1994635)</span></li>
<li>src/includes/KTextEditor/SessionConfigInterface <span style="color: grey">(8c26b7d418e81072df4e7dffe0038d7fdc1e3010)</span></li>
<li>src/includes/KTextEditor/Range <span style="color: grey">(15aad643ee6f1f95b96f579bc66cc84f4873d006)</span></li>
<li>src/includes/KTextEditor/SearchInterface <span style="color: grey">(f7dffc91739e82cceffea35de0632cb19e92ab0a)</span></li>
<li>src/includes/KTextEditor/Plugin <span style="color: grey">(1016b2e5c5f930afcceb1110b00468ee1158cf7e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117017/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>