<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117000/">https://git.reviewboard.kde.org/r/117000/</a>
     </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated March 24, 2014, 11:34 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename kmimetypefactory.h to kmimetypefactory_p.h

This makes it obvious it is not installed.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kbuildsycoca/kbuildmimetypefactory.h <span style="color: grey">(a1c9f064c95191d30f92f5911168547892150729)</span></li>

 <li>src/kbuildsycoca/kbuildservicefactory.cpp <span style="color: grey">(55b2eea17e164bd64e83860a7d42d0fa95c89b84)</span></li>

 <li>src/services/kmimetypefactory.h <span style="color: grey">(239a4cdfa2c3add603c6915ecd967401254cd930)</span></li>

 <li>src/services/kmimetypefactory.cpp <span style="color: grey">(8fedf59170e4a1af59eae726ca873288d06ea432)</span></li>

 <li>src/services/kmimetypetrader.cpp <span style="color: grey">(839579790e6624ff1856d2b5a26307d4da4f3974)</span></li>

 <li>src/services/kservice.cpp <span style="color: grey">(50c86ac1a5dfa1400f7471be48494c323005c47d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117000/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>