<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116959/">https://git.reviewboard.kde.org/r/116959/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 817f47214f94e2d76631cd5e8e87815a8945ebec by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 21st, 2014, 5:15 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 5:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcmutils
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KCModuleProxy: remove deprecated forwarding methods
These have been deprecated since at least kdelibs 4.0, and LXR says the
only user is KCMultiDialog (since I fixed the call in systemsettings).
KCModuleContainer: tidy up overridden methods
Use the "@reimp" macro in the docs and use Q_DECL_OVERRIDE.
KCModuleContainer: move modulelist variables to private object
According to LXR, these were not used by anything.
Remove TODO file
This is full of API changes for KDE 4. Some were done, and others not
(but would probably be considered too disruptive for KF5).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>TODO <span style="color: grey">(82f28e12903e51279ba12871c7b184a97c79a12a)</span></li>
<li>src/kcmodulecontainer.h <span style="color: grey">(68aaeb008195aae154b1fbaf44c6f620753884b0)</span></li>
<li>src/kcmodulecontainer.cpp <span style="color: grey">(5b698ab2e320654a9ff3396c22b8aa239d4395d7)</span></li>
<li>src/kcmoduleproxy.h <span style="color: grey">(d80d519dbf6e4015864d61daf65f67b99c136f26)</span></li>
<li>src/kcmoduleproxy.cpp <span style="color: grey">(c58b68ccb1716493d0537fbfe5a89733ff72e22b)</span></li>
<li>src/kcmultidialog.cpp <span style="color: grey">(cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116959/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>