<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116927/">https://git.reviewboard.kde.org/r/116927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 21st, 2014, 4:10 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this seems to broke kded modules loading here:
Cannot load library /usr/lib64/libkdeinit5_kio_file: (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No such file or directory)</pre>
</blockquote>
<p>On March 21st, 2014, 4:31 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">err, s/kded modules/kio plugins</pre>
</blockquote>
<p>On March 22nd, 2014, 12:34 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I see. The old code *only* worked for kioslaves, and now it works for everything *but* kioslaves. Although I'm not sure why I didn't run into this in my testing.
I think the correct solution here is to do the lookup in klauncher, though.</pre>
</blockquote>
<p>On March 22nd, 2014, 12:58 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, I'm getting the error now. Possibly it was something to do with the multiple patches I had lying around for kinit, kservice and kio.</pre>
</blockquote>
<p>On March 22nd, 2014, 1:27 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://git.reviewboard.kde.org/r/116935/ should fix it.</pre>
</blockquote>
<p>On March 23rd, 2014, 7:30 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FTR: it fixes the issue, tnx. another side-effect left:
Could not open kconf_update using a library: Cannot load library /usr/lib64/libkdeinit5_kconf_update: (/usr/lib64/libkdeinit5_kconf_update.so: cannot open shared object file: No such file or directory)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh. I don't think that ever worked with KF5. See https://git.reviewboard.kde.org/r/117024/</pre>
<br />
<p>- Alex</p>
<br />
<p>On March 20th, 2014, 10:18 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 20, 2014, 10:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix kdeinit module lookup
KLibrary's lookup magic is not so magic these days - is just uses
QCoreApplication::libraryPaths, which is not what we want. Instead, we
let dlopen() do the searching for us, plus hack in a check in the
library installation directory for kinit (since dlopen() called from Qt
does not respect kdeinit5's RUNPATH).
This should cover most common cases (module installed to standard
location, module installed to same location as the kinit framework,
mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to
the normal executable.
Rename kinit_library_path() to generate_socket_name()
This reflects what the function actually does. Also got rid of the
(mostly) ifdef'd-out code that gave the function its original name.
Add comment about fragility of lookup based on installation vars</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed. Ran kdeinit5, which reported that it was launching "libkdeinit5_klauncher", rather than "/home/kf5-devel/kf5/bin/klauncher" as it did previously. klauncher process then has "[kdeinit]" in its process title in `ps xu`.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdeinit/CMakeLists.txt <span style="color: grey">(c4e3c49ea28d4e96be9ee1fa02f801052945d01e)</span></li>
<li>src/kdeinit/kinit.cpp <span style="color: grey">(82d570c4453cf083e525125edd448b97d8d11bd3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>