<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117018/">https://git.reviewboard.kde.org/r/117018/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 43d1f16a04a61646f904e9ed53e559b69919eaed by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 24th, 2014, 12:10 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 12:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kguiaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use qIsNaN() instead of isnan()
Revert "Use std::isnan on compilers that support it"
This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c.
As apol pointed out, qIsNaN would be a better choice.
Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually have to include QtNumeric.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, installs, tests pass (Linux, GCC 4.8).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(f15264e01849b00907afedc262078225ed8756a5)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1)</span></li>
<li>src/colors/kcolorutils.cpp <span style="color: grey">(5f4d0fdeb77d40d42b824c99e08e208aed6f2b93)</span></li>
<li>src/kguiaddons_config.h.cmake <span style="color: grey">(8d5cb897a7e431be298c2d290369b14dbaaa4904)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117018/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>