<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116938/">https://git.reviewboard.kde.org/r/116938/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 886298e6b25152268754179cba9f8d52924da623 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 21st, 2014, 3:50 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 3:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove defunct plugin-loading code, and deprecate KLibrary
KLibrary::factory() tried to load kde3-style plugins (not unreasonable
to drop support for) and kdelibs4-style plugins (which do not work,
since they depended on Qt support). It now does nothing.
This and the KPluginFactory::findPlugin() method leave KLibrary with no
purpose, so deprecate it.
Improve the KPluginLoader documentation
Give KPluginLoader a public static findPlugin method
I noticed that several bits of code used KLibrary or KPluginLoader to
find a plugin, then proceeded to just use QLibrary to resolve functions
from it. This method allows that to be done without actually creating a
KPluginLoader instance that is then only used for its fileName() method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugin/kpluginloader.h <span style="color: grey">(8621914890bf704213d33108d01032a7b36b3484)</span></li>
<li>src/plugin/kpluginloader.cpp <span style="color: grey">(53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6)</span></li>
<li>src/plugin/klibrary.h <span style="color: grey">(78f0701e01b0a24e8895127640ce575e09d93d7c)</span></li>
<li>src/plugin/klibrary.cpp <span style="color: grey">(c77ec32dbb1cbd1ccd6342a082012d2c82575fb8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>