<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116935/">https://git.reviewboard.kde.org/r/116935/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Hrvoje Senjan.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 22, 2014, 1:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extend to fix the issue raised in https://git.reviewboard.kde.org/r/116927/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lookup paths for kioslaves in KLauncher</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lookup paths for kioslaves in KLauncher
If you pass kdeinit anything other than an absolute path, it assumes it
is a normal kdeinit executable - ie, it is an executable <name> in
$PATH, optionally with a libkdeinit5_<name> in a library path.
kioslaves are actually installed as plugins, though, so we do the lookup
in klauncher's requestSlave() function and pass an absolute path to
kdeinit.
Fix up kioslave debug and valgrind modes
valgrind mode with kdeinit still requires the slave module as an
argument, and debug mode cannot work without kdeinit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, installed.
Killed all existing kdeinit5/klauncher/etc instances.
Ran kdeinit5 on one terminal.
Ran kioslavetest from kio/tests on another terminal.
Used it to list /tmp.
kioslavetest's terminal printed the contents of /tmp, and kdeinit5's terminal printed
kdeinit5: Got EXEC_NEW '/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so' from launcher.
kdeinit5: preparing to launch '/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so'
kio_file.so(23605)/(default) [31mQStandardPaths::writableLocation[0m: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-kf5-devel'
kdeinit5: PID 23605 terminated.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klauncher/klauncher.cpp <span style="color: grey">(a8630854af4bd3094b9688c3f9a40d10516d2056)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116935/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>