<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116894/">https://git.reviewboard.kde.org/r/116894/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 335353d1bcb131b00537e3d079a2f96f463ee845 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 19th, 2014, 11:26 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 19, 2014, 11:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean up comments about removed syscoca type numbers
Remove "explanation" of why the desktoptojson target is exported
The explanation was wrong, and it doesn't really need any justification
anyway.
Remove comment about test finding kmailservice from KDE4
It won't find the wrong kmailservice, because the desktop file is now
called kmailservice5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kservicetest.cpp <span style="color: grey">(711fb9b649e580ad474b0cdecd26dcdbfdc302a2)</span></li>
<li>src/desktoptojson/CMakeLists.txt <span style="color: grey">(f106d254e015fc4eccf12fb4437ec221fb64ba1b)</span></li>
<li>src/sycoca/ksycocatype.h <span style="color: grey">(54276a6bc04d8a48be8c4022250453e4c9993279)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116894/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>