<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116962/">https://git.reviewboard.kde.org/r/116962/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update docs for KDesktopFile::isAuthorizedDesktopFile()
The fact that it changed in KDE 4.3 is not so relevant any more.
Remove unhelpful comments
These lines of code do not really require any justification.
Better comment for why KDesktopFile::readPath uses readEntry
Remove old kdelibs4 code
All this ifdef'd-out code just makes it hard to see what's going on.
Remove references to ${_KDE4_KCONFIG_COMPILER_DEP}
Not sure why it would be unset and then used, instead of just not used
at all. LXR says it's not used anywhere else, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5ConfigConfig.cmake.in <span style="color: grey">(12ff7c639493f75ed0c5941c40604d00e7a1b047)</span></li>
<li>KF5ConfigMacros.cmake <span style="color: grey">(aeebee9ea39ab33712131b13ca561136a9bb6309)</span></li>
<li>src/core/kconfig.cpp <span style="color: grey">(4695621ab4c4dbc862c0ddde1b065e19254ab500)</span></li>
<li>src/core/kdesktopfile.h <span style="color: grey">(df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34)</span></li>
<li>src/core/kdesktopfile.cpp <span style="color: grey">(ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4)</span></li>
<li>src/kconf_update/kconf_update.cpp <span style="color: grey">(f8ba16d1c27029b480f19d5580b3edca9ac98bd0)</span></li>
<li>src/kconfig_compiler/CMakeLists.txt <span style="color: grey">(71f2609d870cd00eae3d98c0f3a07504d5973ff0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116962/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>