<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116912/">https://git.reviewboard.kde.org/r/116912/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f022e70fb37aa6828f0c99c36e0fa3d610fe4ef4 by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 20th, 2014, 12:33 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 20, 2014, 12:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KSocks and KSocksSocketDevice
LXR says these are entirely unused, they have been deprecated since 4.0
and k3socks.cpp makes use of the long-deprecated KLibrary::factory()
method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built, installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/includes/CMakeLists.txt <span style="color: grey">(048d474583bbbba1ce9e5f142ad3ffb4d4ccb7f3)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(362855d1a3143a3efd74bee6a850eb11434eb517)</span></li>
<li>src/includes/KNetwork/KSocksSocketDevice <span style="color: grey">(f2b7cea900c73545d751f8b03fdcd0e46e51c659)</span></li>
<li>src/includes/KSocks <span style="color: grey">(bf29d0350fe1241820efffbdb39f72f353123a15)</span></li>
<li>src/kdecore/k3socketdevice.cpp <span style="color: grey">(da772b0196f35870ee1d87b43e4941519bcb661b)</span></li>
<li>src/kdecore/k3socks.h <span style="color: grey">(51f8a4f2443b510b530c2afaa192271b6a6f00aa)</span></li>
<li>src/kdecore/k3socks.cpp <span style="color: grey">(920340b14899b56b300607326e5da6fc810095b8)</span></li>
<li>src/kdecore/k3sockssocketdevice.h <span style="color: grey">(2197ce63f2d96415da5949bdaff83a4f694eef53)</span></li>
<li>src/kdecore/k3sockssocketdevice.cpp <span style="color: grey">(dae2f75fbafbd4f1d91fb8503669220f6bf7475e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116912/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>