<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116927/">https://git.reviewboard.kde.org/r/116927/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix kdeinit module lookup
KLibrary's lookup magic is not so magic these days - is just uses
QCoreApplication::libraryPaths, which is not what we want. Instead, we
let dlopen() do the searching for us, plus hack in a check in the
library installation directory for kinit (since dlopen() called from Qt
does not respect kdeinit5's RUNPATH).
This should cover most common cases (module installed to standard
location, module installed to same location as the kinit framework,
mdoule in LD_LIBRARY_PATH), and if it still fails we just fall back to
the normal executable.
Rename kinit_library_path() to generate_socket_name()
This reflects what the function actually does. Also got rid of the
(mostly) ifdef'd-out code that gave the function its original name.
Add comment about fragility of lookup based on installation vars</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed. Ran kdeinit5, which reported that it was launching "libkdeinit5_klauncher", rather than "/home/kf5-devel/kf5/bin/klauncher" as it did previously. klauncher process then has "[kdeinit]" in its process title in `ps xu`.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdeinit/CMakeLists.txt <span style="color: grey">(c4e3c49ea28d4e96be9ee1fa02f801052945d01e)</span></li>
<li>src/kdeinit/kinit.cpp <span style="color: grey">(82d570c4453cf083e525125edd448b97d8d11bd3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>