<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116934/">https://git.reviewboard.kde.org/r/116934/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated March 20, 2014, 8:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">src/core/slave.cpp also does the same lookup</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KPluginLoader to find kioslaves
KIO slaves are typically installed in PLUGIN_INSTALL_DIR, rather than
QT_PLUGIN_INSTALL_DIR, so we should use KPluginLoader instead of
QPluginLoader to locate them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In combination with https://git.reviewboard.kde.org/r/116935/
Ran
KDE_SLAVE_VALGRIND=file kdeinit5
and use the kioslavetest app to copy a file; the copy was successful, and the terminal running kdeinit5 output
kdeinit5: preparing to launch '/usr/bin/valgrind'
==20134== Memcheck, a memory error detector
==20134== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==20134== Using Valgrind-3.9.0 and LibVEX; rerun with -h for copyright info
==20134== Command: /home/kf5-devel/kf5/lib64/kde5/libexec/kioslave kio_file file local:/tmp/runtime-kf5-devel/klauncherJ19850.slave-socket local:/tmp/runtime-kf5-devel/kioslavetestJ20122.slave-socket
==20134==
(20134)/(default) [31m[34mmain[0m: trying to load "kio_file" from "/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so"
==20134==
==20134== HEAP SUMMARY:
==20134== in use at exit: 5,846 bytes in 42 blocks
==20134== total heap usage: 998 allocs, 956 frees, 672,987 bytes allocated
==20134==
==20134== LEAK SUMMARY:
==20134== definitely lost: 0 bytes in 0 blocks
==20134== indirectly lost: 0 bytes in 0 blocks
==20134== possibly lost: 0 bytes in 0 blocks
==20134== still reachable: 5,846 bytes in 42 blocks
==20134== suppressed: 0 bytes in 0 blocks
==20134== Rerun with --leak-check=full to see details of leaked memory
==20134==
==20134== For counts of detected and suppressed errors, rerun with: -v
==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1)
For the change to src/core/slave.cpp, ran
KDE_FORK_SLAVES=1 ./kioslavetest
and did the same test; uncommented the debug line in that method so it printed
kioslave , "/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so" , "file" , "" , QUrl( "local:/tmp/runtime-kf5-devel/kioslavetestJ32621.slave-socket" )
and the copy was successful.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/slave.cpp <span style="color: grey">(ee84066f96675caaf1fa5ba612c8242eac160c4a)</span></li>
<li>src/kioslave/CMakeLists.txt <span style="color: grey">(64bf7e0f36a1a407dd162e2c0461dedb2f57a13e)</span></li>
<li>src/kioslave/kioslave.cpp <span style="color: grey">(50413d04be29361638ba581383354d79881e844e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116934/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>