<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116087/">https://git.reviewboard.kde.org/r/116087/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 16th, 2014, 9:12 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116087/diff/3/?file=254139#file254139line56" style="color: black; font-weight: bold; text-decoration: underline;">src/kcrash.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QtGui/qpa/qplatformnativeinterface.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just realized that this requires qpa-private headers, which is a problem (breaks compat when upgrading Qt, too). See k-f-d thread "kguiaddons uses qpa headers?".
We could add a QX11Info::startupId() instead?
Makes me wonder how startup notification is supposed to work on wayland though - and whether I should resurrect the idea of a DBus-based startup notification at the upcoming freedesktop meeting.</pre>
</blockquote>
<p>On March 16th, 2014, 4:28 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kevin Krammer queried just how private the private headers really are in that thread...
WRT the D-Bus startup notification, I'm greatly in favour. I think Martin Gräßlin is as well, from previous email/reviewboard threads.</pre>
</blockquote>
<p>On March 16th, 2014, 10:09 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should I then commit the first version of this patch until we have a proper solution?</pre>
</blockquote>
<p>On March 16th, 2014, 10:14 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We just got rid of qpa private headers in kguiaddons, I'm not sure that creating the same issue in kcrash is a good idea, especially since the code works right now, without that.
We could instead add QX11Info::startupId() and ifdef based on the Qt version?</pre>
</blockquote>
<p>On March 16th, 2014, 11:52 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I mean the version where the QByteArray is just stored on the stack to increase the refcount.
Adding QX11Info::startupId() is obviously the better solution, but that will only be useful once we depend on Qt 5.4</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah sorry, I didn't see "first version" when reading too fast.
OK, let's go for that then.</pre>
<br />
<p>- David</p>
<br />
<p>On March 15th, 2014, 3:31 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated March 15, 2014, 3:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcrash
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove usage of strlcpy
We can get the startupId from the QPlatformNativeInterface.
Additionally this means we no longer need to link to KWindowSystem.
REVIEW: 116087</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(d19b97f98e057d5537cf0eb6a8e1997d2a24cb1e)</span></li>
<li>KF5CrashConfig.cmake.in <span style="color: grey">(dcde84376e7ea69e53a26dc2bcba8137ee28a2a4)</span></li>
<li>CMakeLists.txt <span style="color: grey">(b9a6f441abed3c88bf428869c30ef5aebd72fc74)</span></li>
<li>src/strlcpy-fake.c <span style="color: grey">(9b2dc68c466908d11370ba0c4bbe8d315962da5d)</span></li>
<li>src/kcrash.cpp <span style="color: grey">(6c41022206130f186d52ddbb77afd58c429f368f)</span></li>
<li>src/config-strlcpy.h.cmake <span style="color: grey">(5d9163d7a60d89b9792afcdf498af6425a9038a8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116087/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>