<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116012/">https://git.reviewboard.kde.org/r/116012/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116012/diff/1/?file=245826#file245826line183" style="color: black; font-weight: bold; text-decoration: underline;">src/karchive.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * If an archive is opened for writing then you can add a new file</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @deprecated use writeFile(const QString&,const QByteArray&,mode_t,const QString&,const QString&,const QDateTime&,const QDateTime&,const QDateTime&)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I didn't see it. I think it's better
@deprecated since 5.0, use blah, blah
I know it's been already shipped, but it still can be fixed :-)</pre>
</div>
<br />
<p>- David Gil Oliva</p>
<br />
<p>On February 28th, 2014, 12:58 a.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 12:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
karchive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Four commits (in git log order):
Simplify autotests CMakeLists.txt
Separate out tests of deprecated functions to their own file
This allows us to disable deprecation warnings just for that file.
Inline deprecated methods
This both documents how to replace them in the headers and ensures that
enabling or disabling deprecated functions does not affect the ABI.
Use KARCHIVE_NO_DEPRECATED instead of KDE_NO_DEPRECATED</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests pass. No deprecation warnings (before there were two in the tests).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(1da853fe49ec6fca40ccf417db788340124b41e5)</span></li>
<li>autotests/deprecatedtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/karchivetest.cpp <span style="color: grey">(6d6b5848ce9add84736968dd13f529711f895493)</span></li>
<li>src/karchive.h <span style="color: grey">(d4209cf334190dda735fcb4687fa102a4e7a73cd)</span></li>
<li>src/karchive.cpp <span style="color: grey">(a25b85e41618d1f7ae62e7e41966afe1a8aaef8e)</span></li>
<li>src/kfilterdev.h <span style="color: grey">(4a35879a15992d19378c7e9baa9b206e187713fd)</span></li>
<li>src/kfilterdev.cpp <span style="color: grey">(60660a0c08922ee0f4ddaf4ad4d1adf0e7f1c5a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116012/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>