<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116650/">https://git.reviewboard.kde.org/r/116650/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something?
It is added to the "all" target; without this new target, docbooks (and manpages) are not generated at all. Could you please send me the log of the successfull compilation of kde-runtime?
In fact, when I apply the patch to kdoctools I get:
[...]
[ 61%] Automoc for target meinproc5
[ 61%] Built target meinproc5_automoc
[100%] Built target meinproc5
Install the project...
-- Install configuration: "debug"
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsTargets.cmake
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsTargets-debug.cmake
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsConfig.cmake
-- Installing: /opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsConfigVersion.cmake
-- Installing: /opt/kf5/bin/checkXML5
-- Up-to-date: /opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsMacros.cmake
CMake Error at docs/checkXML5/cmake_install.cmake:36 (FILE):
file INSTALL cannot find
"/opt/build-kf5/frameworks/kdoctools/docs/checkXML5/checkXML5.1".
Call Stack (most recent call first):
docs/cmake_install.cmake:37 (INCLUDE)
cmake_install.cmake:71 (INCLUDE)
make: *** [install] Error 1
It seems that in the past multiple targets were allowed (thanks Pino for the hint).
If this analysis is true, I guess ${_targ} should be fixed by adding the parent directory too.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116650/diff/1/?file=252767#file252767line63" style="color: black; font-weight: bold; text-decoration: underline;">KF5DocToolsMacros.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">get_filename_component</span><span class="p">(</span><span class="s">_targ</span> <span class="o">${</span><span class="nv">CMAKE_CURRENT_SOURCE_DIR</span><span class="o">}</span> <span class="s">NAME</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is needed indeed...</pre>
</div>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On March 7th, 2014, 3:05 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While porting the documentation in kde-runtime I realized there was an error because when running cmake it would try to create different targets and some of them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, and it uses the directory name to figure out the filename).
I would have fixed that, but then I realised it was not running any command and nothing depended on it. Am I missing something?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now kde-runtime documentation builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5DocToolsMacros.cmake <span style="color: grey">(6567b67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>