<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116610/">https://git.reviewboard.kde.org/r/116610/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2014, 5:22 p.m. CET, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.
One question though, wasn't it possible to merge properties or properties2? I lack extensive knowledge of this domain, but it looks odd from an API point of view.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that would be a large SC break which might not be worth the effort even if it is possible.
The reason why it is split is AFAIU that NET::Properties consists of 32 flags, thus hitting the bounds of the underlying int back in the days. Given that QFlags still uses either int or unsigned int I guess this border is still valid.</pre>
<br />
<p>- Martin</p>
<br />
<p>On March 5th, 2014, 10:50 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 10:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use flag types in NETRootInfo
This replaces the usage of the unsigned long[] array with
NET::Properties, NET::Properties2, NET::WindowTypes, NET::States and
NET::Actions mixed in - for the fun even in different order
depending on the ctor to use.
This includes the following changes:
* NETRootInfo::event(xcb_generic_event_t*) returns NET::Properties
* new overload added to NETRootInfo::event taking NET::Properties*
and NET::Properties2* as arguments
* existing overload for NETRootInfo::event taking usinged long* as
argument is deprecated and forwards to the new added overload
* NETRootInfo::passedProperties returns NET::Properties and new
methods for Properties2, WindowTypes, States and Actions are added.
This is a SC-break, but there is according to lxr no usage except
in the unit tests
* NETRootInfo::supportedProperties returns NET::Properties and new
methods for Properties2, WindowTypes, States and Actions are added.
This is a SC-break, but there is according to lxr no usage except
in the unit tests
* ctors taking unsigned long* is changed to taking the flags as
arguments. This in an SC-break, but the ctor broke already caused
by the change from Display* to xcb_connection_t*. The ctor for
window manager should only be used by KWin. Other ctor is also
mainly only used in kde-workspace.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tests succeed with 116609 applied. KWin and kde-workspace will get adjusted to test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/netwm_p.h <span style="color: grey">(1c26d47257a4f3ce71c360c394cc5be16f32b18c)</span></li>
<li>src/netwm.h <span style="color: grey">(a5ad46fa1f0255ca6719224079bdea4598b48c51)</span></li>
<li>src/netwm.cpp <span style="color: grey">(288a34348f464e1158640afa1d931d9d05690cc4)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(95c396b65ae0a24db6a276b9b72f4175bb7c14cc)</span></li>
<li>autotests/netrootinfotestwm.cpp <span style="color: grey">(120fbee92d0b22862d8ce746b3b30891ecd9f056)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116610/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>