<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116090/">https://git.reviewboard.kde.org/r/116090/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2014, 10:54 a.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem with doing this in support code is that it is not strictly source compatible. An example this would break is if you want to embed the value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
add_definitions("-DQMAKE=\"${QT_QMAKE_EXECUTABLE}\"")
Any use of QMAKE in the program would then expand to "$<TARGET_FILE:Qt5::qmake>", which is obviously not what was wanted.</pre>
</blockquote>
<p>On March 4th, 2014, 4:43 p.m. CET, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, didn't know that, should I drop this request?</pre>
</blockquote>
<p>On March 5th, 2014, 12:53 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, I don't think it's worth risking breakage for kde4support.</pre>
</blockquote>
<p>On March 5th, 2014, 1:07 p.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Setting the policy instead would probably help though.
This warning is very verbose and not very useful to the developer either.</pre>
</blockquote>
<p>On March 5th, 2014, 1:15 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that seems reasonable. The best approach is to use cmake_policy(PUSH) and cmake_policy(POP) in the relevant files, so it doesn't affect any of the developer's own code (see http://www.cmake.org/cmake/help/v2.8.12/cmake.html#command:cmake_policy ).</pre>
</blockquote>
<p>On March 6th, 2014, 1:07 p.m. CET, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just did that here: https://git.reviewboard.kde.org/r/116628/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually my code was not as complete as this one, and not as good.
The parts which affect internal variables (such as those in KDE4Macros.cmake) can go in. The parts which affect public variables should be changed to instead wrap the location getters in cmake policy changes as Alex suggested (ie: cmake_policy(PUSH) ; cmake_policy(SET CMP0026 OLD) ; ...get some locations... ; cmake_policy(POP))</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On February 26th, 2014, 6:03 p.m. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2014, 6:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use $<TARGET_FILE:...> instead of get_target_property(... LOCATION)
This means CMake no longer warns about Policy CMP0026 is not set when
building projects that need kde4support</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde4support compiles, kde-workspace compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/ECMQt4To5Porting.cmake <span style="color: grey">(4204fa541790aa38c74b9d6f0b2111af2157b2bc)</span></li>
<li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(192094b1c5c6877cd9dfa18dc27338c491d753f3)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6bda0996c118ce212860e02d0505fd3bdc026833)</span></li>
<li>src/KDEUIMacros.cmake <span style="color: grey">(1570df340a672a597a0b7480885c340faca0069d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116090/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>