<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115717/">https://git.reviewboard.kde.org/r/115717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2014, 3:07 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think papering over the X11-ness of kdesu like this is the right approach. Of course, what this framework really needs is a test app; maybe a simple port of the kdesu app from kde-runtime?</pre>
</blockquote>
<p>On February 21st, 2014, 7:58 a.m. CET, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This kind of "papering over" can only be temporary indeed. Just wondering if Martin has the possibility to clean that up better at that stage?
As for the test app: hell yes, definitely needed.</pre>
</blockquote>
<p>On February 21st, 2014, 8:24 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well yes if there's a testapp and that works I can implement it properly. But IIRC kdesu never worked on my setup (not having a password for root).</pre>
</blockquote>
<p>On March 4th, 2014, 9:14 p.m. CET, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can use it for other users than root you know. ;-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, I didn't and which other users? ;-)</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 13th, 2014, 10:41 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2014, 10:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesu
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set
If kdesu is compiled with X11 it required the DISPLAY variable to be
set. This is no longer correct as it might have been compiled with
X11 but is run on Wayland. Thus the code checks now also for
WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support
should become more complete, I do not know how it behaves if we compile
without X11 support. Unfortunately there are no autotests and no test
applications which one could use.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/client.cpp <span style="color: grey">(91bfd78fbca6e5d8d365d924c0260087e3937948)</span></li>
<li>src/kcookie.cpp <span style="color: grey">(59448351696c503b34b7507e9c3fa8efc53139f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>