<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116098/">https://git.reviewboard.kde.org/r/116098/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 68fa427587a38805f27e28cd9b6de1b248b18fe5 by Lamarque V. Souza on behalf of Alex Richardson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 5th, 2014, 2:46 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and Sebastian Kügler.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 2:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libnm-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs
This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g.
openSuSE, since CMake will detect the correct install directory for most
distributions. If for some reason CMake doesn't detect the correct
directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Installed into the right directories after applying the patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9918278)</span></li>
<li>NetworkManagerQt.pc.cmake <span style="color: grey">(2c3ab07)</span></li>
<li>include/CMakeLists.txt <span style="color: grey">(2b51ced)</span></li>
<li>include/settings/CMakeLists.txt <span style="color: grey">(1a00bdb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>