<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116591/">https://git.reviewboard.kde.org/r/116591/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 4, 2014, 10:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">adjusted KWin and Plasma for testing</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use dedicated NET::Properties and NET::Properties2 in NETWinInfo
This replaces the usage of the unsinged long[] array with
NET::Properties as first element and optional NET::Properties2 as
second element by a dedecated variable for each of them.
This includes the following changes:
* NETWinInfo::event(xcb_generic_event_t*) return NET::Properties
* new overload added for NETWinInfo::event taking NET::Properties*
and NET::Properties2* as arguments
* existing overload for NETWinInfo::event taking unsigned long* as
argument is deprecated and forwards to the new added overload
* NETWinInfo::passedProperties returns NET::Properties and a new
NETWinInfo::passedProperties2 is added which returns the
NET::Properties2. This is a SC-break, but it's only used internally
in KWindowInfo
* ctor taking unsigned long* is changed to taking NET::Properties and
NET::Properties2. This is also a SC-break, but the ctor broke already
caused by the change from Display* to xcb_connection_t*
* other ctor is deprecated as the difference is no longer relevant</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit tests still succeed; further testing: KWin and Plasma are still working</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/netwininfotestclient.cpp <span style="color: grey">(030881cf47ddc38b89e49a59dfd5deff309a0038)</span></li>
<li>autotests/netwininfotestwm.cpp <span style="color: grey">(5a6697c56462d52777cc9eec0a3eb5b3d03b7693)</span></li>
<li>src/kwindowinfo_x11.cpp <span style="color: grey">(358bcfedc6c5c75c104fbb4ec3666bd8578bff7d)</span></li>
<li>src/netwm.h <span style="color: grey">(a5ad46fa1f0255ca6719224079bdea4598b48c51)</span></li>
<li>src/netwm.cpp <span style="color: grey">(288a34348f464e1158640afa1d931d9d05690cc4)</span></li>
<li>src/netwm_p.h <span style="color: grey">(1c26d47257a4f3ce71c360c394cc5be16f32b18c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116591/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>