<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116096/">https://git.reviewboard.kde.org/r/116096/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116096/diff/1/?file=246357#file246357line89" style="color: black; font-weight: bold; text-decoration: underline;">autotests/proxymodeltestsuite/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span><span class="p">(</span><span class="s">proxymodeltestsuite_standalone</span><span class="p">)</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, why removing this block while using if(FALSE) on the one above? I'd expect either both to disappear or both to use if(FALSE).</pre>
</div>
<br />
<p>- Kevin Ottens</p>
<br />
<p>On February 26th, 2014, 5:49 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2014, 5:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kitemmodels
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Re-enable autotests
modeltest.(cpp|h) are taken from Qt 5.3. The license header has been
trimmed to clarify which license we are using it under, and to reflect
the fact we use a COPYING.LIB file instead of LICENSE.LGPL.
Grantlee is disabled. That apparently affects some sort of logging functionality, but I haven't really investigated it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests build. 3 out of 4 pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/klinkitemselectionmodeltest.cpp <span style="color: grey">(e1a47e4cf58e85d690c58fb1b40bfdd8cfb81431)</span></li>
<li>autotests/kselectionproxymodeltestsuite.h <span style="color: grey">(6204b7733f995614c43930af03d12d13e0cb2a3f)</span></li>
<li>autotests/proxymodeltestsuite/CMakeLists.txt <span style="color: grey">(972226b7dd3477b7d064ececb307609e67d81670)</span></li>
<li>autotests/proxymodeltestsuite/eventloggerregister.cpp <span style="color: grey">(6be780108c71db6c32cfbb2c88524366435ea301)</span></li>
<li>autotests/proxymodeltestsuite/modelselector.h <span style="color: grey">(c1163084170d4409112949057562abbfa909dc14)</span></li>
<li>autotests/proxymodeltestsuite/modeltest.h <span style="color: grey">(20d5c36e32e69bb69fffad86ccc02e44bfade425)</span></li>
<li>autotests/proxymodeltestsuite/modeltest.cpp <span style="color: grey">(51ad27f3fef5cf0d62e92eb149e4cf9149b45e95)</span></li>
<li>CMakeLists.txt <span style="color: grey">(d153ba3d658ba70a0dca2b9e04b6cdd1e17d9db3)</span></li>
<li>autotests/bihash/CMakeLists.txt <span style="color: grey">(44c965c7597ac48c81bba70f07979b51bf8547aa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116096/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>