<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116462/">https://git.reviewboard.kde.org/r/116462/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bef59bad73e688574a79f79ab5dec93c0542d99c by David Faure to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 27th, 2014, 9:59 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2014, 9:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Keep KSharedConfigPtr("kdeglobals") around in KHintSettings.
This makes KFontSettingsData end up using the same instance, rather than
each of these two classes parsing kdeglobals on startup, in turn.
Had to fix the unittest again, it doesn't use QStandardPaths' testMode,
so it must ensure to set its special environment before the platformtheme
is created.
strace -e open kate |& grep -v NOENT | grep kdeglobals | wc -l
went from 5 to 4.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as described: unittests in frameworkintegration + running kate.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/khintssettings.cpp <span style="color: grey">(c4de4badc6187d841af36e29e083ffd2ca475d82)</span></li>
<li>src/platformtheme/khintssettings.h <span style="color: grey">(8f353837884590bc6a8409df7273435824273f49)</span></li>
<li>src/platformtheme/kfontsettingsdata.cpp <span style="color: grey">(62990ce45c1a175c3b57710c8a38268d08908733)</span></li>
<li>autotests/kfontsettingsdata_unittest.cpp <span style="color: grey">(4ee33fea72905128112226248667499489b1c692)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116462/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>