<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115932/">https://git.reviewboard.kde.org/r/115932/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2014, 10:54 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the example app needs to be more complete as I doubt that everything here would just work (e.g. the States). If you are unsure about how that should work I can schedule some time for it.
Would it be possible to add some Q_PROPRERTIES to the class? E.g. numberOfDesktops or currentDesktop might make more sense with a property instead INVOKABLE.</pre>
</blockquote>
<p>On February 27th, 2014, 11:01 a.m. CET, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My thoughts exactly.
One thing I was thinking about is to create a qml api that is not mirroring the actual c++ api. It is not really object/property oriented.</pre>
</blockquote>
<p>On February 27th, 2014, 11:08 a.m. CET, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What do you guys think about a data model for windows, filterable against screen, desktop, activity containing things like title, icon, position/size, ... that would be a properly behaving model?
That way, it would be awesomely trivial to connect it to window thumbnail items and so on.
Yes, I am volunteering :)</pre>
</blockquote>
<p>On February 27th, 2014, 11:25 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> What do you guys think about a data model for windows
we have that in KWin, feel free to take it as a base (kwin/scripting/scripting_model.(hcpp)). As I'm the only copyright holder I allow the relicense to the frameworks license.</pre>
</blockquote>
<p>On February 27th, 2014, 11:40 a.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Would it be possible to add some Q_PROPRERTIES to the class? E.g. numberOfDesktops or currentDesktop might make more sense with a property instead INVOKABLE.
Yeah, can do that.
> I think the example app needs to be more complete
Well it's an example app, showing how to use the declarative plugin...does it really need to go over all the methods?</pre>
</blockquote>
<p>On February 27th, 2014, 11:52 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> does it really need to go over all the methods?
how do you make sure that the methods actually work without ever writing a test QML script? As said I don't think those methods with enums will work in QML.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QML also doesn't like WId...can it be safely transformed back and forth to long?</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 27th, 2014, 10:23 a.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2014, 10:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a declarative plugin usable from QML. Usage is as easy as "KWindowSystem.workArea(0)" in QML. So far only the workArea is accessible, not sure which other methods should be. All of them?
I've made the import version to match the framework version, so you'd do "import org.kde.kwindowsystem 5.0"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>declarative/kwindowsystemplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(cbae838)</span></li>
<li>declarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarative/kwindowsystemplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarative/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(e10f7c1)</span></li>
<li>tests/test.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115932/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>